Merged
Conversation
Owner
himanusia
commented
May 17, 2025
himanusia
commented
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new 3D assets and updates the project configuration to support a 3D simulation. Key changes include adding new material resource files, a custom floor shader, several car scene definitions, and refactoring the main scene from a 2D Control to a 3D Node while updating project settings (e.g., physics engine).
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tukang-parkir-simulator/scenes/wheel_material.tres | Added a new StandardMaterial3D resource for wheel materials. |
| tukang-parkir-simulator/scenes/scene_manager.tscn | Removed the SceneManager scene resource. |
| tukang-parkir-simulator/scenes/primary_material.tres | Added a new primary material resource. |
| tukang-parkir-simulator/scenes/non_primary_material.tres | Added a new non-primary material resource. |
| tukang-parkir-simulator/scenes/floor.gdshader.uid | Added shader UID file for the floor material. |
| tukang-parkir-simulator/scenes/floor.gdshader | Added a custom shader for floor grid rendering. |
| tukang-parkir-simulator/scenes/car3.tscn | Added a new car3 scene using the newly defined materials. |
| tukang-parkir-simulator/scenes/car2.tscn | Added a new car2 scene using the newly defined materials. |
| tukang-parkir-simulator/project.godot | Updated the main scene reference to use a UID and added physics config. |
| tukang-parkir-simulator/assets/Textures-16.png.import | Removed the texture import file. |
| test/2.txt | Added a new test file. |
| src/utils/utils.hpp | Added operator overloads for the Coordinates struct. |
| src/main_scene/main_scene.hpp | Refactored MainScene to inherit from Node3D and added new 3D members. |
Comments suppressed due to low confidence (1)
src/main_scene/main_scene.hpp:33
- MainScene now inherits from Node3D while still managing UI components like Label and Button. Consider reviewing the UI layout and interaction logic to ensure these controls render and function correctly in a 3D context.
class MainScene : public Node3D {
| void fragment() { | ||
| vec2 coord_on_plane; | ||
|
|
||
| if (grid_plane == 1) { |
There was a problem hiding this comment.
It would be helpful to document the expected values for 'grid_plane' (e.g., 0, 1, and any other value representing the YZ plane) to improve clarity for future maintainers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.